Remove rails as dependency#860
Conversation
|
Thanks. I'd like to avoid needing to vendor minitest-spec-rails. Without it the tests seem to pass for rails 5, but not 4.2. |
|
@lgebhardt yeah that's reasonable. I wanted to confirm that nothing would break in the test suite if the other parts of rails were included (even after removing rails, it was all still being pulled in by minitest-spec-rails). Not sure what you mean by "without it", but I'll push again with the vendored stuff removed and add back into the gemspec |
|
(i tested again on 4.2 as well) |
|
@lgebhardt pushed. I'll squash these when it's ready. |
|
Thanks. Looks ready to squash to me. |
* remove 'rails/all' from test helper * add activerecord and railties to gemspec
|
@lgebhardt ok cool, done. |
|
@quinn Thanks! |
|
Nice work folks :) |
|
why updated dependency of activerecord/railties to 4.1 instead of 4.0 ? 😢 I am using rails4.0 and noticed I couldn't update to 0.9.0. using unsupported old rails is absolutely my bad I understand, |
(this is a work in process probably...)